Changed assert.equal => assert.strictEqual line 56. Cast response to Number()#10002
Closed
jtenenbaum wants to merge 1 commit intonodejs:masterfrom
Closed
Changed assert.equal => assert.strictEqual line 56. Cast response to Number()#10002jtenenbaum wants to merge 1 commit intonodejs:masterfrom
jtenenbaum wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
Please see the commit message guidelines here. |
imyller
added
the
code-and-learn
jasnell
approved these changes
Dec 5, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM with the requested fix to the commit message
Member
lpinca
approved these changes
Dec 9, 2016
italoacasas
approved these changes
Dec 12, 2016
|
Landed f5c2c8c Thanks for the contribution. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
- using strictEqual instead equal - cast `response` to Number() PR-URL: #10002 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2017
- using strictEqual instead equal - cast `response` to Number() PR-URL: #10002 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
- using strictEqual instead equal - cast `response` to Number() PR-URL: #10002 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
- using strictEqual instead equal - cast `response` to Number() PR-URL: #10002 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Number()